[Spring] Require an active scenario before creating beans #1974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glue code context does not require an active scenario. As a result
it was possible to create scenario scoped beans that would be shared
(leak) between scenarios.
An example of this is illustrated below. Because this does require
access to the
GlueCodeScope
it is not possible to do this inpractice.
However without registering the the
GlueCodeScope
at start up Springwill complain about missing the cucumber-glue scope rather then
complain about scope not having started or the missing proxy mode.
So to avoid further confusion:
@ScenarioScope
annotation that sets the correct proxy mode.Related
Types of changes
Checklist: